Skip to content

fix: googlemaps#697 Changed expected error message in to ApiException#708

Merged
jpoehnelt merged 2 commits intogooglemaps:masterfrom
abdul4samad:master
Jan 5, 2021
Merged

fix: googlemaps#697 Changed expected error message in to ApiException#708
jpoehnelt merged 2 commits intogooglemaps:masterfrom
abdul4samad:master

Conversation

@abdul4samad
Copy link
Copy Markdown
Contributor

@abdul4samad abdul4samad commented Jan 5, 2021 •
edited
Loading

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #697 🦕

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 5, 2021
@abdul4samad abdul4samad marked this pull request as ready for review January 5, 2021 12:26
jpoehnelt
jpoehnelt suggested changes Jan 5, 2021
View reviewed changes
Comment thread src/main/java/com/google/maps/errors/ApiException.java Outdated
@abdul4samad
Update src/main/java/com/google/maps/errors/ApiException.java
8d084a8 
Co-authored-by: Justin Poehnelt <jpoehnelt@google.com>
@abdul4samad
Copy link
Copy Markdown
Contributor Author

abdul4samad commented Jan 5, 2021

Thanks @jpoehnelt

@jpoehnelt jpoehnelt merged commit cd0c73f into googlemaps:master Jan 5, 2021
@googlemaps-bot
Copy link
Copy Markdown
Contributor

googlemaps-bot commented Jan 5, 2021

🎉 This PR is included in version 0.15.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

googlemaps-bot pushed a commit that referenced this pull request Jan 5, 2021
@semantic-release-bot
chore(release): 0.15.3 [skip ci]
f269df8 
## [0.15.3](v0.15.2...v0.15.3) (2021-01-05)

### Bug Fixes

* googlemaps[#697](#697) Changed expected error message in to ApiException ([#708](#708)) ([cd0c73f](cd0c73f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jpoehnelt jpoehnelt jpoehnelt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@arriolac arriolac

@jpoehnelt jpoehnelt

Labels

cla: yes This human has signed the Contributor License Agreement. released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Geocoding: API throws OverQueryLimitException instead of OverDailyLimitException

4 participants

@abdul4samad @googlemaps-bot @jpoehnelt @arriolac